Repository navigation
fix(amazonq): require exact approval for sensitive paths - #2952
Open
hezelin-work wants to merge 1 commit into
Open
hezelin-work wants to merge 1 commit into
hezelin-work wants to merge 1 commit into
Conversation
hezelin-work
marked this pull request as ready for review
October 20, 2026 16:47
hezelin-work
force-pushed
the
fix/file-tools-sensitive-approval
branch
from
October 23, 2026 03:04
aa29175 to
177109c
Compare
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
hezelin-work
force-pushed
the
fix/file-tools-sensitive-approval
branch
5 times, most recently
from
October 23, 2026 12:31
74fba47 to
dd58237
Compare
- Credential and system paths need their own approval, not a parent directory's. This also applies to the executeBash working directory and to arguments that the shell can expand to hidden names. - Keep executeBash file checks for approved paths. - Record an approved path after the tool succeeds, and for executeBash only when the command exits normally.
hezelin-work
force-pushed
the
fix/file-tools-sensitive-approval
branch
from
October 23, 2026 12:42
dd58237 to
5ad4093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Path approvals for file tools and shell commands applied more broadly than intended.
Solution
Require a separate approval for credential and system paths, including the working directory and path arguments of shell commands, and for files that share their data with another name on disk. Record an approval only after the tool succeeds, and for a shell command only when the prompt was about running outside the workspace.
Behavior change: the agent may ask again before it uses a credential file or folder, or a file with another name on disk, in a folder the user already approved, including for shell commands. A prompt that covers several files now shows the warning for each of them.
Testing: added unit tests.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.