Repository navigation
fix(amazonq): require exact approval for sensitive paths - #2943
Closed
hezelin-work wants to merge 1 commit into
Closed
hezelin-work wants to merge 1 commit into
hezelin-work wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hezelin-work
marked this pull request as ready for review
October 16, 2026 20:24
- Sensitive paths need their own approval, not a parent directory's. - Keep executeBash file checks for approved paths. - Record an approved path after the tool succeeds.
hezelin-work
force-pushed
the
fix/file-tools-sensitive-approval
branch
from
October 16, 2026 21:45
1d64717 to
aa29175
Compare
Author
|
Moved to #2952. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Path approvals for file tools applied more broadly than intended.
Solution
Require a separate approval for sensitive paths, and record an approval only after the tool succeeds.
Behavior change: the agent may ask again before using a sensitive file in a folder the user already approved.
Testing: added unit tests.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.