Skip to content

zulip: Allow cert_bundle to be a directory. - #951

Open
Johnboard-cmyk wants to merge 1 commit into
zulip:mainfrom
Johnboard-cmyk:cert-bundle-dir-748
Open

Johnboard-cmyk wants to merge 1 commit into
zulip:mainfrom
Johnboard-cmyk:cert-bundle-dir-748

Conversation

@Johnboard-cmyk

Copy link
Copy Markdown

The requests library accepts a directory of CA certificates (such as /etc/ssl/certs) as its verify parameter, but Client rejected any cert_bundle that was not a file. Accept directories as well.

Fixes #748. This supersedes #749, which has been inactive since March 2022.

How did you test this PR?

Tests: new TestCertBundle tests in zulip/tests/test_client.py cover a file bundle, a directory bundle, and a missing path; the full zulip/tests/ suite passes, and ruff and mypy are clean.

@zulipbot

Copy link
Copy Markdown
Member

@Johnboard-cmyk You've referenced #748 in your pull request description, but you have not referenced it in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #748..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

In addition, please make sure your commit structure and messages follow all guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cert Bundle might also be a directory

2 participants