Repository navigation
fix(Type): a union with a class that is no component is left untyped - #2304
Merged
Merged
Conversation
`Types` and `TypeInfoTypeResolver` leave out the `oneOf` of a union when one of its members is a class that is no component, as they do for a property typed with that class alone. A union of components and native types keeps its `oneOf`. The `ClassRef` scratch fixture gains both kinds of union.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A union with a member that is a class without a schema, for example
Thing|int, comes out asoneOf: [{type: integer}, {}].{}matches any value, so an integer matches both members, andoneOfthen rejects it. The union now gets no type, as a property typed with the class alone does.Changes
int, keeps itsoneOf