Repository navigation
fix(Type): a class that is no component is not a nested schema's type - #2303
Merged
Merged
Conversation
`TypeInfoTypeResolver` runs the top level's type check on every nested schema it builds (items, `additionalProperties`, shape properties, `oneOf` and `allOf` members), so a type that maps to nothing is dropped. `LegacyTypeResolver` does the same for items. The `ClassRef` scratch fixture gains a list, a map and a shape of a plain class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In classic mode, an array, map, array shape or union whose element is a class that is not a component writes the class name as the element's
type, for exampleitems: { type: 'App\Thing' }. That is not a JSON Schema type, so the document is invalid. A property typed with the class directly already comes out as{}, and the nested cases now do the same.Changes