Repository navigation
Restructured zhmcclient.Session to prepare for a future BCPII support - #2327
Open
andy-maier wants to merge 1 commit into
Open
andy-maier wants to merge 1 commit into
andy-maier wants to merge 1 commit into
Conversation
andy-maier
force-pushed
the
andy/bcpii-preparation
branch
7 times, most recently
from
November 19, 2026 15:09
258a58e to
b804f73
Compare
Collaborator
Details:
* Added an internal base class 'Transport' for representing the transport used
by a 'zhmcclient.Session' object, and a derived class 'NetworkTransport' for
accessing an HMC via the network using a 'requests.Session' object.
* Removed the 'session' property of 'zhmcclient.Session' and its internal
'self._session' (that was set to 'requests.Session()' when logged on), and
replaced that with an internal 'self._transport' variable that is set during
init and remains set, and is the transport object mentioned above.
There is no need for making the 'self._transport' variable public.
* Restructured the way the zhmcclient.Session.get/post/delete() methods
pass the parameters to the lower layers:
- In the implementation of these methods and the layers below them, the
request data is now put into a local requests.Request object that is passed
down.
Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/bcpii-preparation
branch
from
November 19, 2026 15:29
b804f73 to
74507d5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
Note: This PR is a preparation and does not yet include the actual BCPII support.
I ran the end2end tests against AHPS, and it resulted in the same 50 errors as for the master branch. So the end2end test did not reveal any new issues for this PR.