Skip to content

Restructured zhmcclient.Session to prepare for a future BCPII support - #2327

Open
andy-maier wants to merge 1 commit into
masterfrom
andy/bcpii-preparation
Open

andy-maier wants to merge 1 commit into
masterfrom
andy/bcpii-preparation

Conversation

@andy-maier

@andy-maier andy-maier commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

For details, see the commit message.

Note: This PR is a preparation and does not yet include the actual BCPII support.

I ran the end2end tests against AHPS, and it resulted in the same 50 errors as for the master branch. So the end2end test did not reveal any new issues for this PR.

@andy-maier andy-maier self-assigned this Nov 19, 2026
@andy-maier andy-maier added this to the 1.28.0 milestone Nov 19, 2026
@andy-maier andy-maier linked an issue Nov 19, 2026 that may be closed by this pull request
@andy-maier
andy-maier force-pushed the andy/bcpii-preparation branch 7 times, most recently from 258a58e to b804f73 Compare November 19, 2026 15:09
@coveralls

coveralls commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 79.566% (-0.01%) from 79.577% — andy/bcpii-preparation into master

Details:

* Added an internal base class 'Transport' for representing the transport used
  by a 'zhmcclient.Session' object, and a derived class 'NetworkTransport' for
  accessing an HMC via the network using a 'requests.Session' object.

* Removed the 'session' property of 'zhmcclient.Session' and its internal
  'self._session' (that was set to 'requests.Session()' when logged on), and
  replaced that with an internal 'self._transport' variable that is set during
  init and remains set, and is the transport object mentioned above.
  There is no need for making the 'self._transport' variable public.

* Restructured the way the zhmcclient.Session.get/post/delete() methods
  pass the parameters to the lower layers:

  - In the implementation of these methods and the layers below them, the
    request data is now put into a local requests.Request object that is passed
    down.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
@andy-maier
andy-maier force-pushed the andy/bcpii-preparation branch from b804f73 to 74507d5 Compare November 19, 2026 15:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support BCPII V2 as the interface

2 participants