Feature: add httpx2 support with httpx fallback - #328
Open
CoderJoshDK wants to merge 2 commits into
Open
CoderJoshDK wants to merge 2 commits into
CoderJoshDK wants to merge 2 commits into
Conversation
Deprecate the use of httpx in favor of httpx2.
CoderJoshDK
commented
Oct 1, 2026
Author
There was a problem hiding this comment.
Aware that this file is a bit funky. Honestly, this test can be removed IMO. But up to you.
| "anyio >=3.6.1, <5.0.0", | ||
| "httpx >=0.23.0, <1.0.0", | ||
| "hishel[async,httpx] >=1.3.0, <=2.0.0", | ||
| "hishel[async,httpx] >=1.4.0, <=2.0.0", |
Author
There was a problem hiding this comment.
Bump here because this is the first version that supports httpx2. I want to avoid a really strange case where you somehow have httpx2 but not the version of hishel that supports it and you get a super strange import error / explosion. This also makes the _httpx.py file a bit more reliable in its try-except.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate the use of httpx in favor of httpx2 when supplied.
Closes #321
Replaces #324
If the environment of the caller has httpx2 installed, we use that. Otherwise, we give them a deprecation warning.
In the future, httpx should be dropped and a hard cut to the
httpx2namespace should be used. This is to help avoid client mismatch.