Repository navigation
Conversation
Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
Currently, VIF IP configuration finishes as soon as xenops_server_xen has written the xenstore configuration values. This does not tell us whether IP configuration has succeeded or not, and if it fails, why. Wait for the VM to acknowledge the request (by removing the enabled/ enabled6 values) and return both the error code and error message. Assisted-by: LLM Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
Assisted-by: LLM Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
staticIP configuration mode now accepts adns=a.a.a.a,b.b.b.bsetting that sets the DNS server on the target VIF.The Xenstore schema is as following:
xenserver/device/vif/<id>/static-ip-setting/dns/dns6/If the
dnsordns6key is missing, then it should be interpreted as "don't change the corresponding DNS settings". This retains compatibility with guest agents that don't support DNS setting.If the
dnsordns6key is present but contains no children, then it should be interpreted as "empty the list of DNS servers".The latter (empty the list of DNS servers) can be presented in xenstore, but cannot be represented in XAPI DB or xe, because XAPI DB does not have a way to represent null values.
During
VIF.configure_ipv4/ipv6, XAPI simply sets the xenstore entries and finish immediately. This doesn't tell us if the configuration succeeded or not.Instead, use the following protocol:
xenserver/device/vif/<id>/static-ip-setting/error-codeanderror-msgwith the results.error-msgis ignored iferror-code=0.enabledorenabled6to acknowledge the configuration to XAPI