Repository navigation
Add player notifications to CLI publishing - #72
Merged
Merged
Conversation
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
wavedash publish BUILD_ID --notify-playersto opt into the same update notifications as the publish UI. Require a nonblank summary or patch note locally, and include the notification intent in the interactive confirmation.Send
notifyPlayersto the publish API. Server cooldown failures remain errors with a nonzero exit status and the original actionable message; the CLI does not retry or silently publish without notifications.Validation:
cargo clippy --all-targets -- -D warningspassed.wavedash-devalias against personal dev using a temporary regular-user fixture: first notified publish succeeded, second exited 1 with the 24-hour error and unchanged release state, and publishing without notifications succeeded. Test user/game archived and API key revoked.Requires the companion publish API change to be deployed before releasing the CLI.
Companion API: https://github.com/wvdsh/wavedash/pull/1187
Documentation: https://github.com/wvdsh/docs/pull/51