Skip to content

Add player notifications to CLI publishing - #72

Merged
franzwarning merged 1 commit into
mainfrom
codex/publish-notify-players
Oct 10, 2026
Merged

franzwarning merged 1 commit into
mainfrom
codex/publish-notify-players

Conversation

@franzwarning

@franzwarning franzwarning commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Add wavedash publish BUILD_ID --notify-players to opt into the same update notifications as the publish UI. Require a nonblank summary or patch note locally, and include the notification intent in the interactive confirmation.

Send notifyPlayers to the publish API. Server cooldown failures remain errors with a nonzero exit status and the original actionable message; the CLI does not retry or silently publish without notifications.

Validation:

  • 81 Rust tests passed, including opt-in parsing, request serialization, empty-note rejection, and cooldown error handling.
  • cargo clippy --all-targets -- -D warnings passed.
  • Tested through the actual fish wavedash-dev alias against personal dev using a temporary regular-user fixture: first notified publish succeeded, second exited 1 with the 24-hour error and unchanged release state, and publishing without notifications succeeded. Test user/game archived and API key revoked.

Requires the companion publish API change to be deployed before releasing the CLI.

Companion API: https://github.com/wvdsh/wavedash/pull/1187
Documentation: https://github.com/wvdsh/docs/pull/51

@claude

claude Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@franzwarning
franzwarning merged commit 751a25e into main Oct 10, 2026
9 of 10 checks passed
@franzwarning
franzwarning deleted the codex/publish-notify-players branch October 10, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant