Skip to content

Use cached plugin and theme installs in tests - #192

Merged
schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs
Nov 2, 2026
Merged

schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Switches the feature files to the these installed plugins: / these installed themes: steps from wp-cli/wp-cli-tests#404, and requires wp-cli/wp-cli-tests ^5.4.0.

Measured on this test suite: Behat time -15.8% (187.3 → 157.8 job minutes, summed over the matrix). Details in wp-cli/wp-cli-tests#404.

Summary by CodeRabbit

  • Tests
    • Updated language translation scenarios to configure installed themes and plugins at the required versions, including version changes tested around translation updates.
    • Adjusted theme setup in older WordPress scenarios to use themes that are already installed.
  • Chores
    • Updated the development test-tool version constraint.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a95c08e1-ce71-47da-acb7-959178c1ddfc
Commits

Reviewing files that changed from the base of the PR and between 63c34f0 and 1f86336.

Files selected for processing: 4
  • composer.json
  • features/language-core.feature
  • features/language-plugin.feature
  • features/language-theme.feature

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The development dependency constraint changes to ^5.4.0. Language feature scenarios now declare themes and plugins as installed instead of invoking direct installation commands.

Changes: Language scenario setup

Layer / File(s) Summary
Update installed-asset scenario setup
composer.json, features/language-core.feature, features/language-plugin.feature, features/language-theme.feature
The wp-cli/wp-cli-tests constraint changes to ^5.4.0. Theme and plugin scenarios declare assets as installed, with version-specific setup retained around translation checks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: swissspidy, ernilambar

Merge Risk: Minimal · up to 1f863

The change uses the supported cached-install test steps and updates their dependency constraint without introducing a merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Use cached plugin and theme installs in tests" matches the main change. The PR replaces direct wp plugin install and wp theme install calls in the feature files with the `these installe…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Use cached plugin and theme installs in tests" matches the main change. The PR replaces direct wp plugin install and wp theme install calls in the feature files with the these installed plugins: and these installed themes: steps, and raises the wp-cli-tests dependency to ^5.4.0. The title is specific and short, and it names the primary change from the developer's view. It does not cover the version-specific translation checks or the timing gain, which is acceptable for a title.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the scope:testing Related to testing label Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera force-pushed the measure/cached-extension-installs branch from 3185a11 to 1f86336 Compare November 2, 2026 02:56
@schlessera schlessera changed the title [DO NOT MERGE] Test wp-cli/wp-cli-tests#404 Use cached plugin and theme installs in tests Nov 2, 2026
@schlessera
schlessera marked this pull request as ready for review November 2, 2026 02:56
@schlessera
schlessera requested a review from a team as a code owner November 2, 2026 02:57
@schlessera
schlessera merged commit dfbbb07 into main Nov 2, 2026
52 checks passed
@schlessera
schlessera deleted the measure/cached-extension-installs branch November 2, 2026 03:03
@schlessera schlessera added this to the 3.0.2 milestone Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant