Repository navigation
fix: accept a package minor newer than the Helm Chart - #72
Closed
desaintmartin wants to merge 1 commit into
Closed
desaintmartin wants to merge 1 commit into
desaintmartin wants to merge 1 commit into
Conversation
The check compared major.minor, so every minor release of the package needed a new Helm Chart appVersion first. Chartreuse 7.1.0 refuses to start with the Helm Chart appVersion 7.0.0. A minor release of the package keeps the Helm Chart contract. The check now accepts the same major and a package minor greater or equal to the Helm Chart minor. A newer Helm Chart minor still aborts, because the Helm Chart can use options that the package does not know.
desaintmartin
force-pushed
the
fix/check-major-version-only
branch
from
October 20, 2026 05:51
dd7303f to
a743f91
Compare
desaintmartin
changed the title
Member
Author
|
Closed: the Helm Chart appVersion follows the package minor instead. The wiremind chart gets appVersion 7.1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_safe_runcompares the package version with the Helm ChartappVersion(HELM_CHART_APP_VERSION). It comparedmajor.minor, so every minor release of the package needed a new Helm Chart release first.Chartreuse 7.1.0 refuses to start with the Helm Chart
appVersion7.0.0:Rule
A Helm Chart release can still force a minimum package version by raising its
appVersionminor.2.10>2.9). A missing minor (2,2.) counts as 0.Tests