Repository navigation
React Native 0.86 / Expo SDK 57 - #10
Merged
Merged
Conversation
Our 240ddf4 re-applied upstream's RN 0.85 instead of merging it; trees differ only by the WillowTree app.json customizations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep the expanded Expo skill set; accept upstream's removal of the deprecated alias skills; restore the local create-adr skill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upstream dropped package-lock.json in the RN 0.86 update. Update the README and AGENTS.md to match, document how to opt into npm, and record the decision in ADR 0010. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
expo 57.0.27, react-native 0.86.3 and matching expo-* patch versions via `npx expo install expo@latest && npx expo install --fix`. expo-doctor: 21/21 checks pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Explain what the template includes (dev builds, CNG, app variants, libraries, quality gates, testing, AI agents), add command, script and project structure references plus troubleshooting, drop the fork-for-your-organization section, and document how to maintain the TELUS Digital fork against upstream. Flag Yarn as the recommended package manager. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stephanie Cure Chegwin (Scure21)
requested a review
from Luis Camargo (LuisCamargoM)
October 6, 2026 20:08
Luis Camargo (LuisCamargoM)
requested changes
Oct 7, 2026
Luis Camargo (LuisCamargoM)
left a comment
Luis Camargo (LuisCamargoM)
left a comment
Collaborator
There was a problem hiding this comment.
Nice work! The RN 0.86 / Expo 57 bump and the npm → Yarn switch look consistent across CI, Husky and the docs.
I left a few comments so anyone can pick up the template and use it safely in any project:
- Variants: Maestro targets the production id while
yarn iosinstalls.dev, and builds withoutAPP_VARIANTsilently get the.devid (there's noeas.json). - Skills:
expo-skill-feedbacksends data to Expo through an unpinnednpx, which is a concern for client projects. The web/API-route skills contradict ADR 0004. - CI:
--frozen-lockfilekeeps the lock file actually enforced.
Also, could we get one yarn ios / yarn android run on a simulator or device before merging, since the device build hasn't been verified yet?
yarn ios / yarn android install the .dev variant, so the flow targeted an app that isn't installed by default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The template leaves distribution (EAS, Fastlane, custom CI) to each team, so explain that every build must set APP_VARIANT, and how that works with EAS profiles and Fastlane schemes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The skill runs an unpinned remote package that sends data to Expo, which isn't appropriate for client projects. AGENTS.md now requires explicit user approval. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop eas-hosting, expo-web-to-native, expo-dom (web/API routes, see ADR 0004), expo-tailwind-setup (conflicts with src/theme) and expo-skill-eval (internal expo/skills tooling). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use yarn install --frozen-lockfile so a stale yarn.lock fails the check instead of being re-resolved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Thanks for the thorough review! All five comments are addressed (replies on each thread), and I ran the build on an iOS device and an Android emulator. Ready for another look. |
Luis Camargo (LuisCamargoM)
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the template to React Native 0.86 / Expo SDK 57 from upstream (jpdriver/react-native-template
next) while keeping our customizations (owner,appleTeamId).APP_VARIANT(.dev/.previewids) +scripts/switch-variant.sh,patch-package, dependency/skill upgrade scripts, Ruby 3.2.11, Yarn-only.skills/update(expanded Expo Skills); drops upstream-deprecated aliases, keeps localcreate-adr.com.willowtreeapps.myapp.Verified: lint, Prettier,
tsc, Jest,expo-doctor(21/21),./scripts/init.shwith prebuild + pod install on both platforms, and a device build on an iOS device and an Android emulator.Jira Ticket
Checklist
Screenshots
N/A
GIF
🤖 Generated with Claude Code