Skip to content

[WV-4667]ManageMyCandidates: "Edit candidate profile" should open drawer [TEAM REVIEW] #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaleMcGrew merged 1 commit into from
Oct 17, 2026
Merged

[WV-4667]ManageMyCandidates: "Edit candidate profile" should open drawer [TEAM REVIEW] #4967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/js/pages/ManageMyCandidates/ManageMyCandidatesLanding.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import { useHistory, useParams } from 'react-router-dom';
import styled from 'styled-components';
import TagManager from 'react-gtm-module';
import DesignTokenColors from '../../common/components/Style/DesignTokenColors';
import PoliticianActions from '../../common/actions/PoliticianActions';
import PoliticianStore from '../../common/stores/PoliticianStore';
import { ImportInviteIcon } from '../../components/More/ImportInviteIcon';
import { PageContentContainer } from '../../components/Style/pageLayoutStyles';
import AppObservableStore from '../../common/stores/AppObservableStore';
import VoterStore from '../../stores/VoterStore';
import { getPageDetails } from '../../utils/lookupPageNameAndPageTypeDict';

Expand Down Expand Up @@ -65,7 +67,7 @@ export default function ManageMyCandidatesLanding () {
const selectedPolitician = politiciansToManage.find((politician) => politician.politician_we_vote_id === selectedPoliticianWeVoteId) || null;

useEffect(() => {
if (!selectedPoliticianWeVoteId && politiciansToManage.length > 0) {
if ((!selectedPoliticianWeVoteId && politiciansToManage.length > 0) || politiciansToManage.length === 1) {
setSelectedPoliticianWeVoteId(politiciansToManage[0].politician_we_vote_id);
}
}, [politiciansToManage, selectedPoliticianWeVoteId]);
Expand Down Expand Up @@ -120,16 +122,18 @@ export default function ManageMyCandidatesLanding () {
handleNavScroll();
}, []);

useEffect(() => {
if (politiciansToManage.length === 1) {
setSelectedPoliticianWeVoteId(
politiciansToManage[0].politician_we_vote_id
);
}
}, [politiciansToManage]);

// Main render
const handleClaimEdit = () => history.push(`/candidate/${selectedPoliticianWeVoteId}/edit`);
const handleClaimEdit = useCallback(() => {
const politician = PoliticianStore.getPoliticianByWeVoteId(selectedPoliticianWeVoteId);
if (!politician?.politician_we_vote_id) return;
PoliticianActions.politicianRetrieve(politician.politician_we_vote_id);
AppObservableStore.setPoliticianWeVoteIdBeingViewed(selectedPoliticianWeVoteId);
AppObservableStore.setDrawerOpen('politicianSelfEditDrawerOpen', true);

}, [selectedPoliticianWeVoteId]);


const handleClaimImport = () => history.push('/managecandidates');
const handleClaimTracking = () => history.push('/managecandidates/tracking');
const handleClaimAnalytics = () => history.push('/managecandidates/analytics');
Expand Down Expand Up @@ -219,7 +223,7 @@ export default function ManageMyCandidatesLanding () {

<SideDivider />

<NavPill id="editCandidateProfileNavButton-desktop" as="button" $active={false} onClick={() => { pushDataLayer('editCandidateProfileNavButton-desktop', selectedPoliticianWeVoteId); handleClaimEdit(); }}>
<NavPill id="editCandidateProfileNavButton-desktop" as="button" $active={false} onClick={() => { pushDataLayer('editCandidateProfileNavButton-desktop', selectedPoliticianWeVoteId);handleClaimEdit(); }}>
<PillIcon><EditIcon fontSize="small" /></PillIcon>
Edit candidate profile
</NavPill>
Expand Down
Loading