Repository navigation
fix(cc-store): bump @webex/contact-center to 3.12.0-next.159 and update teams type - #753
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f05b79265d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
mkesavan13
left a comment
There was a problem hiding this comment.
Kindly address the one comment provided, add new evidence and merge the PR.
Thanks for the PR, Ria.
There was a problem hiding this comment.
Can we please upgrade the webex package as well and test the oAuth flow once?
There was a problem hiding this comment.
Checked the oAuth Flow, it works as expected after the change.
https://app.vidcast.io/share/edc5ffa8-7ede-475c-8e57-37e93f3ddf63
Thank you for your contribution! |
COMPLETES < CAI-8404 >
This pull request addresses
The
@webex/contact-centerSDK previously typedProfile.teamswith a shape that didn'tmatch the
Teamtype the store re-exports, sostore.tscarried a@ts-expect-errorsuppression pointing at CAI-6762. The widgets already consumed
team.id/team.name(see
station-login.tsx), but the shared test fixture still used the old{teamId, teamName}shape, so our mocks diverged from what the SDK actually returns.SDK
3.12.0-next.159corrects theteamstyping, which lets us drop the suppression andalign the fixture with reality.
by making the following changes
@webex/contact-centerfrom3.12.0-next.148to3.12.0-next.159inpackages/contact-center/store/package.json.@webex/contact-centerfrom3.12.0-next.133to3.12.0-next.159inwidgets-samples/cc/samples-cc-react-app/package.jsonso the sample app matches the store.@ts-expect-errorsuppression (and its CAI-6762 reference) abovethis.teams = response.teamsinpackages/contact-center/store/src/store.ts— theassignment now type-checks against the SDK's corrected
Team[].mockProfile.teamsinpackages/contact-center/test-fixtures/src/fixtures.tsfrom{teamId, teamName}to the fullTeamshape (id,name,teamType,teamStatus,active,siteId,siteName,userIds,rankQueuesForTeam,queueRankings).yarn.lockfor the dependency bump.Change Type
The following scenarios were tested
The testing is done with the amplify link
yarn build:dev— all packages compile with no TypeScript errors, confirmingthis.teams = response.teamsis valid without the suppression.yarn test:cc-widgets— all 9 CC package suites pass (1,762 passed, 7 skipped, 0 failures).yarn workspace @webex/cc-store test:unit— 317 passed, 3 skipped; store coverage at95.46% statements.
Station-login team dropdown tests pass against the updated fixture, confirming the new
Teamshape still rendersteam.idas the option value andteam.nameas the label.The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.
Vidcast: https://app.vidcast.io/share/2048aa7f-1da7-4611-86c4-1af3e9efa693