Skip to content

fix(cc-store): bump @webex/contact-center to 3.12.0-next.159 and update teams type - #753

Merged
riag23 merged 3 commits into
webex:nextfrom
riag23:anchor-point
Oct 20, 2026
Merged

riag23 merged 3 commits into
webex:nextfrom
riag23:anchor-point

Conversation

@riag23

@riag23 riag23 commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

COMPLETES < CAI-8404 >

This pull request addresses

The @webex/contact-center SDK previously typed Profile.teams with a shape that didn't
match the Team type the store re-exports, so store.ts carried a @ts-expect-error
suppression pointing at CAI-6762. The widgets already consumed team.id / team.name
(see station-login.tsx), but the shared test fixture still used the old
{teamId, teamName} shape, so our mocks diverged from what the SDK actually returns.

SDK 3.12.0-next.159 corrects the teams typing, which lets us drop the suppression and
align the fixture with reality.

by making the following changes

  • Bumped @webex/contact-center from 3.12.0-next.148 to 3.12.0-next.159 in
    packages/contact-center/store/package.json.
  • Bumped @webex/contact-center from 3.12.0-next.133 to 3.12.0-next.159 in
    widgets-samples/cc/samples-cc-react-app/package.json so the sample app matches the store.
  • Removed the @ts-expect-error suppression (and its CAI-6762 reference) above
    this.teams = response.teams in packages/contact-center/store/src/store.ts — the
    assignment now type-checks against the SDK's corrected Team[].
  • Updated mockProfile.teams in packages/contact-center/test-fixtures/src/fixtures.ts from
    {teamId, teamName} to the full Team shape (id, name, teamType, teamStatus,
    active, siteId, siteName, userIds, rankQueuesForTeam, queueRankings).
  • Regenerated yarn.lock for the dependency bump.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link

  • yarn build:dev — all packages compile with no TypeScript errors, confirming
    this.teams = response.teams is valid without the suppression.

  • yarn test:cc-widgets — all 9 CC package suites pass (1,762 passed, 7 skipped, 0 failures).

  • yarn workspace @webex/cc-store test:unit — 317 passed, 3 skipped; store coverage at
    95.46% statements.

  • Station-login team dropdown tests pass against the updated fixture, confirming the new
    Team shape still renders team.id as the option value and team.name as the label.

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Cursor
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

Vidcast: https://app.vidcast.io/share/2048aa7f-1da7-4611-86c4-1af3e9efa693

@riag23
riag23 requested a review from a team as a code owner October 19, 2026 09:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T08:23:59.277371Z 734b408 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@riag23 riag23 added the validated Indicates that the PR is ready for actions label Oct 19, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f05b79265d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/contact-center/store/package.json
@aws-amplify-us-east-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-753.d1b38q61t1z947.amplifyapp.com

@github-actions github-actions Bot removed the validated Indicates that the PR is ready for actions label Oct 20, 2026
@riag23 riag23 added the validated Indicates that the PR is ready for actions label Oct 20, 2026

@mkesavan13 mkesavan13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly address the one comment provided, add new evidence and merge the PR.

Thanks for the PR, Ria.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please upgrade the webex package as well and test the oAuth flow once?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the oAuth Flow, it works as expected after the change.
https://app.vidcast.io/share/edc5ffa8-7ede-475c-8e57-37e93f3ddf63

@github-actions github-actions Bot removed the validated Indicates that the PR is ready for actions label Oct 20, 2026
@riag23 riag23 added the validated Indicates that the PR is ready for actions label Oct 20, 2026
@riag23
riag23 merged commit fc0764c into webex:next Oct 20, 2026
7 checks passed
@riag23
riag23 deleted the anchor-point branch October 20, 2026 08:41
@github-actions

Copy link
Copy Markdown
🎉 Your changes are now available!
Released in: webex-cc-widgets-v1.28.0-next.64
📖 View full changelog →
Packages Updated Version
@webex/cc-widgets 1.28.0-next.64
@webex/cc-ai-assistant 0.0.0-next.15
@webex/cc-components 1.28.0-next.54
@webex/cc-digital-channels 0.0.0-next.32
@webex/cc-station-login 1.28.0-next.54
@webex/cc-store 1.28.0-next.36
@webex/cc-task 1.28.0-next.57
@webex/cc-ui-logging 1.28.0-next.38
@webex/cc-user-state 1.28.0-next.55
@webex/test-fixtures 0.0.0-next.1
samples-cc-react-app 0.0.0-next.1
samples-cc-wc-app 0.0.0-next.1

Thank you for your contribution!
🤖 This is an automated message. For queries, please contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants