Repository navigation
CI: smoke-test a freshly scaffolded library - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
Adds a
scaffold-smokejob (Linux, every PR) runningtests/smoke_scaffold.sh: scaffoldsmoke-libwithcreate_project.py, then in the generated projectuv sync --extra dev,ruff check,ruff format --check,pytest,mypy src,uv build; finally install the wheel into a throwaway venv and import it from the temp dir above the project, asserting the module path is in the venv's site-packages. The stdlib unittest suite and the existingtestsjob are unchanged.Real defect found and fixed: the first run failed
ruff format --check. The scaffold wrote the__init__.pydocstring via!r(single quotes); it now usesjson.dumps, giving a double-quoted literal.Verification
bash tests/smoke_scaffold.shpasses locally (ruff 0.17.2);unittest discover62 OK.import osin the template__init__.py-> script fails (F401).where = ["docs"]-> fails at pytest collection (never reaches the wheel step).exclude = ["*"]inpackages.find(the scaffold uses setuptools, sopackagesdoes not apply) -> ruff/pytest/mypy/uv buildall pass; only the out-of-tree wheel import fails (ModuleNotFoundError). This is the one that shows the import step guards something.Tool versions are whatever the scaffold's dev extra resolves; no pins or repo-level lint config added.
Screenshots
n/a — no user-visible change.