Repository navigation
[autopilot] skills: pin timezone and test DST days in testing-strategy - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a short section to the testing-strategy skill's ambient-state chapter, plus two checklist lines.
Pattern: date-grouping logic (daily totals, 'midnight today', fixed 24h arithmetic) passes on UTC CI and on laptops but is wrong on 23/25-hour DST days; a frozen clock doesn't help because the local day depends on the process timezone, which many runtimes read only at startup. The guidance: pin the zone in a child process (or pass an explicit ZoneInfo), use a real transition date, assert exact per-day values, and cover the exact-midnight and future-event boundaries.
Readers get a concrete recipe for tests that actually fail on the DST bug instead of depending on the runner's zone.