[reczkok]

Sending an ImageBitmap to a worklet runtime aborts the app. In my case it was a bitmap decoded with createImageBitmap on the JS thread and handed to a scene running on a createWorkletRuntime worker. Other WebGPU objects (buffers, textures, the device) cross fine.

EXC_CRASH (SIGABRT), abort() called, thread WebGPUSerializerRuntime_queue
  __cxa_throw                                         libc++abi.dylib
  worklets::CustomSerializable::toJSValue(jsi::Runtime&)
  worklets::SerializableArray::toJSValue(jsi::Runtime&)
  worklets::SerializableObject::toJSValue(jsi::Runtime&)
  worklets::SerializableWorklet::toJSValue(jsi::Runtime&)

The exception thrown there is No native class registered for brand: ImageBitmap.

What

Unboxing a WebGPU object on another runtime looks up its class brand in NativeObjectRegistry. A brand is only registered by that class's installConstructor. RNWebGPUManager::installConstructors calls it for every WebGPU class except ImageBitmap, so its brand is never registered, and the throw inside the Worklets serializer terminates the app.

Fix

Add ImageBitmap::installConstructor(runtime) to installConstructors, next to the other classes. As a side effect, ImageBitmap now exists as a global on the main runtime and on runtimes that call installWebGPU(). x instanceof ImageBitmap then works there as it does on the web; before, it threw a ReferenceError (three.js checks texture.image instanceof ImageBitmap without a typeof guard in TextureNode).

Test

WorkletSerialization.spec.ts gains a case that decodes a PNG with createImageBitmap, sends the bitmap to a worklet runtime and back, and checks its size there, instanceof ImageBitmap on that runtime, and that the same object comes back. I ran it on an iPhone. It passes with the fix, and without it the app aborts with the crash above. I haven't run it on Android.

Canvas has the same gap: it's the only other native object class missing from installConstructors.

[wcandillon]

that's a great catch thank you ☺️

[github-actions]

🎉 This PR is included in version 0.17.0 🎉

The release is available on:

• v0.17.0
• GitHub release

Your semantic-release bot 📦🚀