Skip to content

Support POSTGRES_DB for PostgreSQL provisioning - #489

Open
j0k3r wants to merge 2 commits into
masterfrom
fix/postgresql-admin-database
Open

j0k3r wants to merge 2 commits into
masterfrom
fix/postgresql-admin-database

Conversation

@j0k3r

@j0k3r j0k3r commented Oct 28, 2026

Copy link
Copy Markdown
Member

Use PGDATABASE when set, otherwise POSTGRES_DB, falling back to POSTGRES_USER like before.

Use `PGDATABASE` when set, otherwise `POSTGRES_DB`, falling back to `POSTGRES_USER` like before.
@j0k3r j0k3r linked an issue Oct 28, 2026 that may be closed by this pull request
@j0k3r
j0k3r requested a review from Kdecherf October 28, 2026 15:11
@obarbier

Copy link
Copy Markdown

Thanks for this. This was a pain. I will take a look into this

@yguedidi yguedidi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review

Comment thread tests/test_postgresql.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where this file is executed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is handle by py.test (line 53 of .github/workflows/test.yml) because the file is inside tests/ folder and match test_*.py (like jest or phpunit will do for js or php files)

Comment thread README.md Resolved
Comment thread README.md Resolved
@j0k3r
j0k3r requested a review from yguedidi November 5, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Postgres error database does not exist

3 participants