Repository navigation
Fix a mismatch between AVX2 and scalar FDCT paths - #40
Merged
Merged
Conversation
Owner
|
Because I'm planning to make the main branch heading towards 0.8 with some minor breaking changes I've back ported this with c9b6309 to a 0.7 branch that will be release as 0.7.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AVX2 code was using
_mm256_set1_epi32but then interpreted the result as a vector ofi16instead ofi32. This caused the values to become[2, 0, 2, 0, ...]instead of[2, 2, 2, 2, ...]as intended and done in the scalar path.This PR adds a test demonstrating the issue, then fixes it.