Skip to content

Fix -Werror build of rpy_publisher - #55

Merged
CurryMonsters merged 1 commit into
mainfrom
fix/rpy-publisher-werror
Oct 7, 2026
Merged

CurryMonsters merged 1 commit into
mainfrom
fix/rpy-publisher-werror

Conversation

@CurryMonsters

Copy link
Copy Markdown
Member

Passing {} as the default value to declare_parameter<std::vectorstd::string> triggers "converting to ParameterDescriptor from initializer list would use explicit constructor" under -Wall -Wextra -Werror, which CI uses. Spell out the default as std::vectorstd::string{}.

Passing {} as the default value to declare_parameter<std::vector<std::string>>
triggers "converting to ParameterDescriptor from initializer list would use
explicit constructor" under -Wall -Wextra -Werror, which CI uses. Spell out
the default as std::vector<std::string>{}.
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.86%. Comparing base (172b932) to head (3826fb6).

Files with missing lines Patch % Lines
vortex_utility_nodes/src/rpy_publisher.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   62.97%   62.86%   -0.11%     
==========================================
  Files          15       15              
  Lines        1723     1726       +3     
  Branches      819      819              
==========================================
  Hits         1085     1085              
- Misses        410      413       +3     
  Partials      228      228              
Flag Coverage Δ
unittests 62.86% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
vortex_utility_nodes/src/rpy_publisher.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CurryMonsters
CurryMonsters merged commit 524a199 into main Oct 7, 2026
2 checks passed
@CurryMonsters
CurryMonsters deleted the fix/rpy-publisher-werror branch October 7, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant