Repository navigation
Feat/waypoint manager reference filter - #54
Merged
Merged
Conversation
- controlled_error(): position and orientation error over the DOFs a waypoint mode controls. - has_converged() overload with ConvergenceTolerance; the threshold version keeps its results. - Waypoint gets convergence_threshold, position_tolerance, orientation_tolerance and hold_time_sec, converted from the message. - dependencies.repos: vortex-msgs from development.
- Waypoint loses convergence_threshold and its conversion. - WaypointGoal: position_tolerance and orientation_tolerance instead of convergence_threshold; YAML keys position_tolerance and orientation_tolerance_deg.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 63.41% 62.97% -0.45%
==========================================
Files 15 15
Lines 1711 1723 +12
Branches 807 819 +12
==========================================
Hits 1085 1085
- Misses 398 410 +12
Partials 228 228
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added position and orientation tolerances instead of only one convergence_threshoold.