Repository navigation
build: make build-release.sh portable to macOS - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-release.shcould not run on macOS:sha256sumis absent and BSD tar rejects--sort=name/--mtime=@<epoch>.sha256helper that falls back toshasum -a 256(identical output format).--sort=name/--mtimewith a portableset_tarball_mtimesthat normalises each staged file's mtime to the source epoch (date -u -don GNU,-ron BSD;TZ=UTC touch -t).--sort=nameis a no-op on GNU tar;--owner=0 --group=0 --numeric-ownerwork on both.Verified on macOS: all four archives build,
shasum -a 256 --checkpasses, entries show uid/gid 0 and the source-epoch mtime, the extracted binary reports the injected version/commit/date, and two runs with identical inputs produce identical checksums. CI (GNU tar) keeps the same flags and output.