Repository navigation
build: derive release ldflags from the Makefile - #44
Merged
Merged
Conversation
vmrocha
force-pushed
the
build/dedupe-ldflags
branch
from
October 19, 2026 02:06
12d4975 to
a56fcdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three
-Xmetadata flags were duplicated inMakefileandscripts/build-release.sh, which is how the tap formula drifted.build-release.shnow callsmake buildper target withBINARY/VERSION/COMMIT/BUILD_DATEoverrides, so theMakefileis the single source of the ldflags."$(BINARY)"in the build recipe so paths with spaces work.Verified locally: a cross-built
darwin/arm64binary reports the passed version, commit, and build date;make checkpasses.Note: the Homebrew formula keeps its own ldflags (it builds from the tap, not this repo) — that copy is still updated by the release workflow for
commit/date, and derivesversionfrom the tag.