Repository navigation
Account for geometry orientation and translation - #906
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: bfdbc37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Micheal Parks (micheal-parks)
changed the title
Micheal Parks (micheal-parks)
marked this pull request as ready for review
October 20, 2026 19:58
Micheal Parks (micheal-parks)
requested a review
from Devin T. Currie (DTCurrie)
October 20, 2026 20:17
Devin T. Currie (DTCurrie)
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frame geometries can carry their own translation and orientation offset from the frame origin. It's an undocumented rdk feature, and the visualizer used to ignore it and draw the shape at the frame origin. With this PR, the visualizer draws those offsets for typed and untyped geometries, keeps them when a geometry is resized or reshaped instead of wiping them from the config, and clears a stale offset when the geometry is removed. The visualizer never writes or edits these offsets, and they are left out of what the LLM scene builder sees.
Furthermore details panel changes were made: when a frame's geometry is offset from the frame origin, the details panel now shows that offset as read-only position and orientation rows under the geometry section. Before, the panel showed only the frame's own pose, which gave no hint why the shape was drawn somewhere else.