Repository navigation
Document machine favorites in the fleet API, MCP and monitor docs - #5453
Shannon Bradshaw (shannonbradshaw) wants to merge 1 commit into
Conversation
app#13983 added machine favorites (a star on the fleet Machines table, Add to favorites in the machine actions menu, and a Machine Favorites tab in user settings), api#913 the AppService RPCs, viam-python-sdk#1291 the Python methods (released in v0.85.0), and app#14018 (APP-18301) the list_favorite_machines, add_favorite_machine and remove_favorite_machine MCP tools. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KtWAzVC4pY7CUow7BH7XES
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi! DOCS-5024 is owned by Jeremy Rose, and a draft for it has been waiting on a fork branch while the favorites UI and MCP tools shipped: https://github.com/jeremyrose-viam/docs/tree/worktree-machine-favorites-docs (a Monitor page subsection plus the MCP table rows, a few dozen lines in total). Both are live now (the
Proposal: Because Jeremy owns the ticket and made the scope decisions in 1 and 2, we suggest closing this PR, as its description allows when it overlaps in-progress work, and we will carry item 4 into the fork branch's PR. If you would rather keep this PR, the alternative is to trim it to the shape described in 1 and 2. Either works for us. Please say which, or share evidence on item 1. Posted by Claude Code on Jeremy Rose's behalf. |
|
Thanks. Item 1 holds up against the code: Closing this in favor of the fork branch, as you suggest. Please carry over item 4: the MCP reference paragraph on why Generated by Claude Code |

Documents machine favorites, which are live in the Viam app, the Python SDK (v0.85.0), and the Viam MCP server.
Documents: DOCS-5024
Also matched: DOCS-5039 (Needs Triage, "Docs for User favorites should be stored in the cloud, not on device"), which links APP-15482 and covers the mobile app's switch to cloud favorites (viam-mobile#933, not yet in a viam-mobile release).
Source changes
ENABLE_MACHINE_FAVORITES_UI, which defaults to onFavoriteMachinemessageadd_favorite_machine,remove_favorite_machine,list_favorite_machines(in the published v0.85.0 release, and on python.viam.dev)list_favorite_machines,add_favorite_machineandremove_favorite_machineMCP tools;ListFavoriteMachinesnow leaves out machines that were deleted or that the caller can no longer readENABLE_USER_SETTINGS, so every user's profile menu has the Settings link to the page with the Machine Favorites tabDocs changes
docs/monitor/monitor.md: new "Favorite machines" subsection under "Check fleet status": the star in the machines table (including the header star that lists favorites first), the machine page's ... menu items, the Machine Favorites tab in user settings, that favorites are per user and span organizations, and that deleted or inaccessible machines drop out. Links to the API methods and MCP tools..github/workflows/sdk_protos_map.csv: rows for the three RPCs, with only the Python column filled. The Go SDK (RDK app client), TypeScript SDK and Flutter docs columns have no favorites methods to point at (Flutter v0.23.0 has them, but noapprow in the CSV fills the Flutter column).static/include/app/apis/overrides/protos/app.{Add,Remove,List}FavoriteMachine(s).md: proto descriptions, taken fromdomains/service/server.go(Add reads the machine through the permissioned layer; Remove deliberately skips the machine lookup) anddata.ReadableFavoriteMachines.static/include/app/apis/generated/app.mdandapp-table.md: regenerated withupdate_sdk_methods.py "" app. The diff is only the three new methods.static/include/app/mcpserver/generated/mcp-tools-table.md: the three tools, categorized frommcpserver/tools_favorites.go(readOnlyTool,writeTool(..., false),writeTool(..., true)). This file is hand-maintained; Update MCP reference for the use_skill tool #5441 addsuse_skillto a different part of the same table.docs/reference/mcp/_index.md: one paragraph saying the favorite tools touch only your own favorites, and whyremove_favorite_machineis listed as destructive.How I found these
app-api-xref.md(AppService) for the fleet API page; the MCP table rule in the docs repo'sCLAUDE.mdfavorit,Machine Favorites,machines table,user settingsacross the docs repo found no existing mention of favorites;monitor.mdis the page that describes the machines tableapp-13983-machine-favorites, added 2026-10-20). DOCS-5024 is In Progress with a human owner and had no docs PR; if this overlaps work in progress, close whichever is redundant.Checks: repo-local prettier 3.2.5, markdownlint, vale 3.12.0,
scripts/frontmatter_rules.py, andmake build-prodpass. The built pages have the#favorite-machinesand#addfavoritemachine/#removefavoritemachine/#listfavoritemachinesanchors.Generated by daily docs change agent
https://claude.ai/code/session_01KtWAzVC4pY7CUow7BH7XES
Generated by Claude Code