Repository navigation
RSDK-14822: Let a user_permissions entry name several users - #936
Merged
Merged
Conversation
Each UserPermission names exactly one user, so when app compiles an access policy every member sharing a permission set repeats the whole list. Owners and operators all carry the full allowlist, so auth.user_permissions grows with members x permissions. Add `repeated User users`, declared first since it supersedes `user`: a writer should emit users, and a reader should ignore user when users is set. `user` keeps field 1 for the wire and stays readable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sagie Maoz (n0nick)
added
the
ready-for-protos
Sagie Maoz (n0nick)
requested review from
Benjamin Rewis (benjirewis),
Cheuk (cheukt) and
Evgeni Dobranov (edobranov)
October 26, 2026 19:13
Sagie Maoz (n0nick)
removed
the
ready-for-protos
Benjamin Rewis (benjirewis)
left a comment
Benjamin Rewis (benjirewis)
left a comment
Member
There was a problem hiding this comment.
Pretty much LGTM.
| // user is a single User these permissions apply to. Superseded by users: | ||
| // prefer users in new writers, and expect readers to ignore user when users | ||
| // is set. | ||
| User user = 1; |
There was a problem hiding this comment.
Any reason to place these fields in 3, 2, 1 order?
Member
Author
There was a problem hiding this comment.
yes, I want to prefer users over user and eventually deprecate user, so in terms of humans reading it i want users to be more visible :)
Benjamin Rewis (benjirewis)
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of APP-17623 (Access policy management). First of three PRs: api → rdk (RSDK-14822) → app (APP-18398).
With this change, a single
UserPermissionobject can describe multiple users, making for smaller config paylod. This is especially useful when App renders the full list of org owners and operators that are mapped to the full allowlist.This should eventually replace the
userfield which will be deprecated.🤖 Generated with Claude Code