Repository navigation
Backtick docker.io image reference in RegisterCustomTrainingContainerRequest comment - #933
Open
Jeremy Rose (jeremyrose-viam) wants to merge 1 commit into
Conversation
Jeremy Rose (jeremyrose-viam)
marked this pull request as ready for review
October 20, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr for human readers
The
image_uricomment inml_training.protois parsed into a broken link and two broken images by TypeDoc. The backticks avoid this.Summary
RegisterCustomTrainingContainerRequest.image_uricomment containsdocker.io/library/<image>:<tag>as plain prose. The TypeScript SDK's TypeDoc build autolinksdocker.io/library/ashttp://docker.io/library/(non-HTTPS target) and parses<image>as an HTML<img>tag with nosrcoralt. This was flagged by the TS SDK's scheduled Link Check workflow (run, auto-filed as DOCS-5035): 3 errors onclasses/mlTrainingApi.RegisterCustomTrainingContainerRequest.html.PackageConfig.Name).Test plan
v0.1.596) with this one-line change, then rantypedoc+htmltest: 0 errors across 1213 documents (3 errors without the change). The field now renders as<code>docker.io/library/<image>:<tag></code>.autoapi+napoleon, nitpicky-n): built the Python SDK docs before and after, applying the backticked text to the generatedml_training_pb2.pyidocstring. A separatebuf generaterun with the SDK'smypyplugin confirmed the generated docstring is the proto comment verbatim, so the hand edit matches real output (the only diff between generating from the unfixed and fixed proto is that line). No new warnings, and 4 existingpy:class reference target not foundwarnings for this field go away. The field now renders in full,docker.io/library/<image>:<tag>; before, napoleon cut it off after<image>.Go and C++ are expected to be unaffected, as in PR 897: Go renders field comments as raw source text, and C++ bindings don't carry comments.
🤖 Generated with Claude Code