Repository navigation
Fix six SDK gaps from gh-v1's C2–C3; tick plan 001 - #43
Merged
jallers merged 2 commits intoNov 7, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016NSWj9gL1oCubj5e2anVkb
- batch.run sends a batch of only aliased updates/executes (with guard
off) instead of treating it as nothing to do; Described.deferred lists
them, and the receipt notes they are unsnapshotted and not reversed.
- A failure reading back after the send throws BatchRecordError carrying
the receipt (sent, outcome, created, touched, reverse); only `after` is
incomplete. The record is built from the response before any read-back.
- confirm sees receipt.names: the touched assets' numbers and names, looked
up once (no second lookup after the send).
- namesOf takes an onFailure callback; runBatch turns failed lookups into
receipt.notes instead of swallowing them.
- An unset single relation, sent as { _oid: "NULL" }, translates to null
(with or without a schema; dropped from a multi-value list).
- Rank translates to a number (32-bit integers sent as strings); generated
types follow.
Live (v1sdktesting): an aliased QuickClose batch runs and is named; the
full integration tier passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016NSWj9gL1oCubj5e2anVkb
jallers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the six SDK gaps the gh-v1 session found in C2–C3 (gh-v1#36, #37), and ticks the plan 001 items that merged today.
batch.runnow sends a batch made only of aliased updates or executes (withguard: false). It used to treat it as nothing to do. A read-back failure after the send now throwsBatchRecordErrorwith the full receipt.confirmsees the touched assets' names, and failed name lookups becomereceipt.notes.{ _oid: "NULL" }, now reads asnull. Rank values (Order) are now numbers, and the generated types follow.All 103 unit tests pass. On v1sdktesting the full live suite passes, including a new test where an aliased QuickClose batch runs and gets a named receipt.
🤖 Generated with Claude Code
https://claude.ai/code/session_016NSWj9gL1oCubj5e2anVkb