Repository navigation
Conversation
Author
|
Live validation is now complete for commit
The PR description now records the deployment URL, packaging detail and coverage limits. I'm marking this ready for review; the issue is not closed until the fix is accepted. An affected application's confirmation would still be useful. |
denusklo
marked this pull request as ready for review
October 3, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #650.
NodejsLambdawithhandler: 'launcher.js'andawsLambdaHandler: 'launcher.launcher'. Keep the existing named CommonJS export and disable helper/source-map injection./var/taskwhenLAMBDA_TASK_ROOTis absent, without injecting that reserved deployment environment variable.The generic
Lambdaconstructor drops the extra launcher metadata. The existing build-utils dependency already exportsNodejsLambda.Live Vercel validation
Deployed runtime commit
20514de4e85e22a3e1ffc21e2738e1fa298e3043to a new isolated project using CLI 62.2.0, Linux prebuilt output, Node.js 22.x and bundled PHP 8.5.2.Preview: https://php-pr654-smoke-20261003-35x999dxl-denusklos-projects.vercel.app
The Preview retains Vercel Authentication protection. No existing application, production environment or application secrets were used.
vercel curlprovided authenticated access.10/10 live checks passed: GET/query preservation, subsequent GET, form POST, UTF-8 JSON POST, binary POST, multipart upload/hash, multiple response cookies and cookie return, a two-request PHP session round trip, exact binary response bytes with HTTP201, and HTTP418 status propagation. The session observation is limited to those sequential requests, not a claim of cross-instance persistence.
The collected Preview request logs contain 25 requests: 21 HTTP200, two HTTP201 and two intentional HTTP418 responses. No 5xx responses or matching invocation/module/export/startup failure markers appeared in that captured window.
The local builder cache was linked to the checked-out PR. Its generated
filePathMapreferenced files outside the fixture upload directory, so the initial upload failed before invocation. For the successful deployment, all 107 referenced files were copied byte-for-byte into the function directory with SHA256/mode checks and only thefilePathMapoptimization was removed. Handler/runtime/environment metadata and runtime source were unchanged. This validates the deployed runtime fix, not a new npm release or every CLI source-upload configuration.An initial UTF-8 JSON check passed text through Windows curl argv and sent a single-byte
é. A standalone loopback curl probe reproduced that client encoding issue without Vercel. The final JSON check sends an explicit UTF-8 file and verifies exact received bytes.Other verification
vercel buildpasses on Linux with CLI50.4.5 and CLI62.2.0, including output metadata, mapped files and executable modes.Coverage is Node22/PHP8.5.2 on this deployment. Other Node/PHP versions, regions and full application frameworks are not established by this smoke. Feedback from affected #650 reporters is welcome. When integrating #652, the overlapping CGI and bundle-key test expectations need reconciliation; this PR intentionally does not include the Windows packaging fix.