Repository navigation
Add ci test for AAP login - #162
Merged
Merged
Conversation
mbaldessari
approved these changes
Nov 9, 2026
|
|
||
| # Dismiss welcome screen if visible | ||
| welcome = page.get_by_role("button", name="Close") | ||
| if welcome.is_visible(timeout=60): |
Contributor
There was a problem hiding this comment.
In a follow up maybe drop the timeout, seems like it is a noop anyways (https://playwright.dev/python/docs/api/class-locator#locator-is-visible)
|
|
||
| # Verify that the script returns the same password | ||
| result = subprocess.run( | ||
| ["bash", "../../pattern.sh", "../../scripts/ansible_get_credentials.sh"], |
Contributor
There was a problem hiding this comment.
If you ever do an update here, maybe use file to build an absolute path
Contributor
|
Just tiny nits you might want to address later on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MBP-1198]