Repository navigation
ci: run Format and Clippy in the pinned debian image - #329
Merged
Merged
Conversation
Both jobs ran on the runner's own toolchain, which lags the images by a release or two, and rustfmt and clippy change between releases. The move to Rust 1.99 passed every CI job while `make check` in the rebuilt image failed on a lint new in 1.99; only the local gate caught it. Both jobs now build the debian image, as the Docker test jobs do, and run there, so the lint CI applies is the one a contributor runs. Each job prints the compiler version it used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both jobs ran on the runner's own toolchain, which lags the pinned images by a release or two, and rustfmt and clippy change between releases. #327 (Rust 1.99) passed every CI job while
make checkin the rebuilt image failed onassert_is_empty, new in 1.99; only the local gate caught it.Both jobs now build the debian image, with the same retry the Docker test jobs use, and run there:
cargo fmt --all --check, and the same three clippy passesmake checkruns. Each printsrustc --versionso the log shows which compiler judged. actionlint clean. The proof is this PR's own run: the Clippy job log must say 1.99.