Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clap strips a
=that starts a value attached to a short option, soenv -C=/etc pwdran in/etcinstead of./=/etc. The same went for-a=NAME, clustered forms like-vC=/etc, and-S'-C=/etc pwd'.-C=failed with "cannot change directory to ''", and-vu=FOOunsetFOOand exited 0 where GNU rejects it.The arguments are now passed through
preserve_attached_equalsbefore clap, the same approach aspreserve_prefix_equalsin fmt. It doubles the=after-a,-Cor-uso that clap's stripping leaves the value intact. It stops at the first operand or--and skips detached option values, so arguments meant for the command are untouched. A-uvalue starting with=now reaches the existing invalid-name check, so the cluster form fails with 125 like-u=FOOalready did.test_short_option_attached_value_keeps_leading_equalsand the new-vu=case indisallow_equals_sign_on_short_unset_optionfail on main.Closes #15754