Repository navigation
fmt: treat -N operands after -- as file names - #15837
Merged
cakebaker merged 1 commit intoOct 26, 2026
Merged
Conversation
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmt -- -9 notes.txttook-9as the obsolete-WIDTHoption instead of a file name. clap'sindex_ofdoes not count--, so the value looked exactly likefmt -9 notes.txt. Depending on the position it was dropped and used as the width, rejected with "invalid option", or (fmt -- -9alone) the file list came out empty and stdin was read.Operands after
--now go into a separate hidden positional withlast(true), so they never reach the-WIDTHdetection and are appended to the file list as they are.fmt -9 fileand the "only when it is the first option" error are unchanged, and so is--help.test_fmt_negative_number_file_after_double_dashfails on main.Closes #15751