[oech3]

Android can be tested on the CI. https://docs.rs/rustix/latest/rustix/termios/struct.Termios.html#structfield.line_discipline

[xtqqczze]

Has compilation been checked locally on all affected targets?

[oech3]

No. I'll restrict this PR to android if I need to much care for minor targets missing from CI.

[xtqqczze]

Has compilation been checked locally on all affected targets?

I don't think it's too much an imposition to ask if the package can be compiled on affected targets. For the record, the changes compile successfully on fuchsia and haiku when rebased onto #15563:

$ RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std=std \
  -p uu_stty --lib --all-features \
  --target x86_64-unknown-fuchsia \
  --target x86_64-unknown-haiku

[xtqqczze]

The changes seemed reasonable, I don't understand why the PR was closed.

[oech3]

But haiku will be broken by rustix soon due to SpecialCodes? I don't want to stop development just for the target.

[xtqqczze]

These changes compile on haiku, so there’s no issue for now. If a future change breaks haiku and is otherwise justified, support for that target can be disabled via cfg.

[oech3]

I missed it was still nix.

coreutils/src/uu/stty/src/stty.rs

Lines 953 to 957 in 744e299

	// nix only defines Termios's `line_discipline` field on these platforms
	#[cfg(any(target_os = "linux", target_os = "android"))]
	{
	_termios.line_discipline = *n;
	}

[sylvestre]

could you please use the same cfg list in apply_special_setting for line N? it is still linux/android only there (and the comment still says nix)

[oech3]

Unfortunately, it is actually using nix. We need to switch to rustix at 1st.