Skip to content

stty: simplify string_to_flag #15459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 1 commit into from
Oct 17, 2026
Merged

stty: simplify string_to_flag #15459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions src/uu/stty/src/stty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,25 +719,17 @@ fn string_to_flag(option: &str) -> Option<AllFlags<'_>> {
let remove = option.starts_with('-');
let name = option.trim_start_matches('-');

for cflag in CONTROL_FLAGS {
if name == cflag.name {
return Some(AllFlags::ControlFlags((cflag, remove)));
}
if let Some(cflag) = CONTROL_FLAGS.iter().find(|f| f.name == name) {
return Some(AllFlags::ControlFlags((cflag, remove)));
}
for iflag in INPUT_FLAGS {
if name == iflag.name {
return Some(AllFlags::InputFlags((iflag, remove)));
}
if let Some(iflag) = INPUT_FLAGS.iter().find(|f| f.name == name) {
return Some(AllFlags::InputFlags((iflag, remove)));
}
for lflag in LOCAL_FLAGS {
if name == lflag.name {
return Some(AllFlags::LocalFlags((lflag, remove)));
}
if let Some(lflag) = LOCAL_FLAGS.iter().find(|f| f.name == name) {
return Some(AllFlags::LocalFlags((lflag, remove)));
}
for oflag in OUTPUT_FLAGS {
if name == oflag.name {
return Some(AllFlags::OutputFlags((oflag, remove)));
}
if let Some(oflag) = OUTPUT_FLAGS.iter().find(|f| f.name == name) {
return Some(AllFlags::OutputFlags((oflag, remove)));
}
None
}
Expand Down
Loading