Repository navigation
ci(wasi): enable wasmtime tracing for debug logging - #15453
Merged
Merged
Conversation
eduardomourar
commented
Oct 17, 2026
eduardomourar
commented
Contributor
- Add WASMTIME_LOG environment variable to trace WASI syscalls when Actions debug logging is enabled
- Add WASMTIME_LOG_NO_CONTEXT environment variable to reduce trace verbosity
- Tracing is only active when runner.debug is '1', disabled otherwise for cleaner output
eduardomourar
force-pushed
the
wasi-wasmtime-log-debug
branch
from
October 17, 2026 10:54
d961add to
c7ea869
Compare
sylvestre
reviewed
Oct 17, 2026
| if: matrix.job.target == 'wasm32-wasip1' | ||
| env: | ||
| RUSTFLAGS: ${{ matrix.job.rust-flags }} | ||
| # Trace WASI syscalls (strace-style) when Actions step debug logging is on; |
Contributor
There was a problem hiding this comment.
would it make more sense on the "Run unit tests" step, where cargo runs wasmtime directly?
sylvestre
reviewed
Oct 17, 2026
| RUSTFLAGS: ${{ matrix.job.rust-flags }} | ||
| # Trace WASI syscalls (strace-style) when Actions step debug logging is on; | ||
| # verbose, so off otherwise. | ||
| WASMTIME_LOG: ${{ runner.debug == '1' && 'wasmtime_wasi=trace' || '' }} |
Contributor
There was a problem hiding this comment.
does this reach wasmtime? uutests calls env_clear() and only forwards PATH/HOME/LD_PRELOAD, so i think it's dropped
https://github.com/uutils/coreutils/blob/main/tests/uutests/src/lib/util.rs#L1986
sylvestre
reviewed
Oct 17, 2026
| RUSTFLAGS: ${{ matrix.job.rust-flags }} | ||
| # Trace WASI syscalls (strace-style) when Actions step debug logging is on; | ||
| # verbose, so off otherwise. | ||
| WASMTIME_LOG: ${{ runner.debug == '1' && 'wasmtime_wasi=trace' || '' }} |
Contributor
There was a problem hiding this comment.
even if forwarded, the trace goes to stderr and would break the stderr checks, no?
eduardomourar
force-pushed
the
wasi-wasmtime-log-debug
branch
from
October 17, 2026 16:17
c7ea869 to
a693105
Compare
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.