Repository navigation
mv: diagnose trailing slashes on regular-file sources - #15379
Merged
sylvestre merged 1 commit intoOct 17, 2026
Merged
Conversation
sylvestre
reviewed
Oct 16, 2026
| }; | ||
|
|
||
| // WASI may return file metadata for a trailing-slash path instead of ENOTDIR. | ||
| if source_metadata.is_file() && path_ends_with_terminator(source) { |
Contributor
There was a problem hiding this comment.
could be merged into the let-else above with a .filter(...), no? it's the same error twice
Contributor
Author
There was a problem hiding this comment.
Moved the metadata check into .filter(...) on the let-else, removing the duplicated error handling. Native and WASI tests pass; squashed and pushed.
limadog9
force-pushed
the
fix/mv-source-trailing-slash-wasi
branch
from
October 16, 2026 13:30
974e041 to
4eeeeb7
Compare
| test_ls::test_ls_a_dotdot_no_error_on_wasi \ | ||
| test_ls::test_ls_al_no_capabilities_insufficient_on_wasi \ | ||
| test_md5sum:: test_mkdir:: test_mktemp:: test_nl:: test_nproc:: test_numfmt:: test_od:: \ | ||
| test_mv::test_mv_dir_into_file_where_both_are_files \ |
Contributor
There was a problem hiding this comment.
This won't be necessary if we merged #15320 as we will run the whole mv command integration tests.
eduardomourar
approved these changes
Oct 17, 2026
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject a trailing slash on a regular-file source when WASI incorrectly accepts its metadata. Strengthen the existing regression and include it in WASI CI.
Closes #15370.