Repository navigation
Conversation
| doctest = false | ||
|
|
||
| [target.'cfg(unix)'.dependencies] | ||
| [target.'cfg(all(unix, not(any(target_os = "aix", target_os = "dragonfly"))))'.dependencies] |
There was a problem hiding this comment.
Missing clap means we cannot build anyway. Is this worth to increase complexity?
There was a problem hiding this comment.
seems less complex to be explicit about configuration
There was a problem hiding this comment.
Why? not(unix) is much simpler and we cannot support aix in any cases.
There was a problem hiding this comment.
Missing clap means we cannot build anyway
what do you mean by this?
There was a problem hiding this comment.
All of our utility depends on clap. So there is no reason to cfg out it.
There was a problem hiding this comment.
You should build uucore only manually. No? But I don't think that it is useful for someone.
There was a problem hiding this comment.
To add check-only CI for less common targets, it would be helpful if commands like the following could succeed:
RUSTC_BOOTSTRAP=1 cargo hack clippy -Zbuild-std \
--quiet --workspace --all-features \
--target=powerpc64-ibm-aixThere was a problem hiding this comment.
But build-std is high cost to run on the all CI. Is threre any pre-built std we can use?
There was a problem hiding this comment.
That's just an example, -Zbuild-std wouldn't be necessary for most targets.
There was a problem hiding this comment.
Do you just want to avoid fetching unnecessary crates? Then, this change is making a sense.
This branch has not been deployed
2 participants
Refine the
sttytarget configuration to explicitly exclude unsupported platforms, skipping compilation where it would otherwise fail.Relates to: #14912.