Repository navigation
Conversation
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | factor_five_38_bit_primes |
1.6 s | 1.7 s | -5.48% |
| ⚡ | Simulation | factor_three_39_bit_primes |
567 ms | 357.1 ms | +58.78% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing oech3:stty-unsafe (0ad3f39) with main (7654e67)
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
8c0b529 to
39bc936
Compare
ff11e70 to
f100d7d
Compare
|
GNU testsuite comparison: |
9be3124 to
d420658
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Would it be possible to separate the refactor replacing |
|
It is very difficult since |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
@oech3 Could you please clarify in the PR description whether these changes support arbitrary baud rates across all platforms, or only on Linux? |
This comment was marked as outdated.
This comment was marked as outdated.
|
I don't think that we need to support all labeled targets, but yes. https://github.com/bytecodealliance/rustix/blob/287214b889865d8e1406a0ee71cc409b6f6191c8/src/termios/types.rs#L740 . Missing macOS and bsd are not problem since they use any baud (as same as |
|
By switching from |
3a756ab to
70ed160
Compare
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
a561bf5 to
0ad3f39
Compare
rustixmanages baud rate byu32on all platforms. But OS itself should support any baud to actually use any baud. This PR adds support for any baud on Linux kernel (since bsd was already supported atnixcrate).rustixhasu32-> enum decoder.