Skip to content

GnuTests.yml: let root tests run the uutils build #15005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 2 commits into from
Oct 13, 2026
Merged

GnuTests.yml: let root tests run the uutils build #15005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9823c75
GnuTests.yml: let root tests run the uutils build
abendrothj Oct 1, 2026
f687351
GnuTests.yml: fail if the non-root user cannot run the uutils build
abendrothj Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/GnuTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@ jobs:
- name: Run GNU root tests
shell: bash
run: |
## Root tests drop to nobody via `chroot --user`. /home/runner is
## 0750, so that user cannot reach our build dir and PATH lookup silently
## falls back to the runner's own /usr/bin coreutils. Allow traversal.
dir="${GITHUB_WORKSPACE}"
while [ "${dir}" != / ]; do sudo chmod o+x "${dir}"; dir=$(dirname "${dir}"); done
## Fail here if that user still cannot run our build, instead of letting the
## tests pass or fail on whatever coreutils the runner image ships.
sudo -u nobody "${GITHUB_WORKSPACE}/uutils/target/release-small/id" -u

@sylvestre sylvestre Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment says $NON_ROOT_USERNAME but here it is hardcoded to nobody, could you please use the same in both?

@abendrothj abendrothj Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

## Run GNU root tests
path_GNU='gnu'
path_UUTILS='uutils'
Expand Down
Loading