Repository navigation
Conversation
|
sorry but i am not going to revert anything until we have a CI running for redox |
|
I think we don't need to revert this since we were not running test(impossible?) for Redox on the CI previously. |
|
I think we should add a check-only job at the very least: cargo check --all-targets --features feat_os_unix_redox --target x86_64-unknown-redoxWe can set |
|
Sounds good |
This comment was marked as outdated.
This comment was marked as outdated.
|
Do we really need to hurry supporting test on redox? Most logic are shared with other platforms. |
d2139df to
e8df3ba
Compare
Merging this PR will improve performance by 56.76%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | three_39_bit_primes |
591.3 ms | 260.7 ms | ×2.3 |
| ⚡ | thirteen_39_bit_primes |
9.6 s | 8.9 s | +8.34% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing xtqqczze:GH14664 (8bfe21f) with main (8b27533)2
Footnotes
-
342 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(c5a3ce5) during the generation of this report, so 8b27533 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
5787bfb to
5489611
Compare
|
If we replaced |
e3871ea to
17ede27
Compare
Closes #14914.
Reverts #14664.