Skip to content

feat(install): gate by target support - #14586

Merged
sylvestre merged 1 commit into
uutils:mainfrom
xtqqczze:gate-install
Oct 18, 2026
Merged

feat(install): gate by target support#14586
sylvestre merged 1 commit into
uutils:mainfrom
xtqqczze:gate-install

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes #14924.

@sylvestre

sylvestre commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

This is quite intrusive for niche archs / os

@xtqqczze xtqqczze mentioned this pull request Sep 15, 2026
Closed
@xtqqczze

xtqqczze commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

@sylvestre You did raise this exact issue in #14537, though. The changes are mostly just amending the existing cfg conditions.

@xtqqczze xtqqczze changed the title install: avoid safe_traversal on unsupported platforms install: gate by target support Sep 15, 2026
@xtqqczze

This comment was marked as outdated.

Sign in to view
@xtqqczze
xtqqczze force-pushed the gate-install branch 3 times, most recently from 108789c to 4be3480 Compare September 15, 2026 21:57
@github-actions

github-actions Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

@xtqqczze

xtqqczze commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

This is quite intrusive for niche archs / os

Since we don't build on Windows or WASI, I gated install to Unix which simplified the conditions.

@xtqqczze
xtqqczze marked this pull request as ready for review September 15, 2026 23:10
@xtqqczze

xtqqczze commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

@sylvestre Would you please review this?

@xtqqczze xtqqczze changed the title install: gate by target support feat(install): gate by target support Sep 18, 2026
@xtqqczze
xtqqczze force-pushed the gate-install branch 2 times, most recently from 2829f2c to f9709d1 Compare September 25, 2026 16:54
@xtqqczze
xtqqczze marked this pull request as draft September 28, 2026 15:20
@xtqqczze xtqqczze self-assigned this Sep 28, 2026
@xtqqczze

xtqqczze commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Depends on #14865, closing for now.

@xtqqczze xtqqczze closed this Sep 29, 2026
@xtqqczze xtqqczze reopened this Oct 15, 2026
@xtqqczze

xtqqczze commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

Since #15030, AIX and Hurd are supported targets.

@xtqqczze
build(install): gate by target support
8bab5ce 
Gate `install` to Unix targets.
@xtqqczze xtqqczze removed their assignment Oct 18, 2026
@xtqqczze
xtqqczze marked this pull request as ready for review October 18, 2026 03:25
@sylvestre
sylvestre merged commit dd33372 into uutils:main Oct 18, 2026
99 checks passed
@sylvestre

sylvestre commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Thanks for your PR

@xtqqczze
xtqqczze deleted the gate-install branch October 18, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

install: gate by target support

2 participants

@xtqqczze @sylvestre