Repository navigation
base32, base64, basenc: drop the "error: " from the invalid-input message - #14396
Socialpranker wants to merge 1 commit into
Conversation
|
Pushed one more commit: For the record, the one red job here ( |
|
GNU testsuite comparison: |
|
Could you please squash your commits ? Thanks |
| } else if ignore_garbage { | ||
| continue; | ||
| } else { | ||
| return Err(USimpleError::new(1, "error: invalid input")); |
There was a problem hiding this comment.
Localised as base-common-invalid-input in base_common.rs/.ftl, sha a8d7da6.
| if !input.len().is_multiple_of(4) { | ||
| return Err(USimpleError::new( | ||
| 1, | ||
| "error: invalid input (length must be multiple of 4 characters)", |
There was a problem hiding this comment.
should be localised too
There was a problem hiding this comment.
Localised as encoding-error-invalid-input/encoding-error-invalid-input-z85-length in uucore/encoding.rs/.ftl, sha a8d7da6.
7b7e1f7 to
a8d7da6
Compare
|
Squashed to a single commit, sha a8d7da6. |
Merging this PR will degrade performance by 13.49%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | dd_copy_default |
19.7 KB | 28.4 KB | -30.7% |
| ❌ | Memory | dd_copy_4k_blocks |
23 KB | 31.7 KB | -27.47% |
| ❌ | Memory | dd_copy_partial |
23 KB | 31.8 KB | -27.46% |
| ❌ | Memory | dd_copy_with_skip |
23.3 KB | 32 KB | -27.21% |
| ❌ | Memory | dd_copy_with_seek |
23.3 KB | 32 KB | -27.21% |
| ❌ | Memory | dd_copy_8k_blocks |
27 KB | 35.7 KB | -24.39% |
| ❌ | Memory | dd_copy_64k_blocks |
83 KB | 91.7 KB | -9.5% |
| ❌ | Memory | dd_copy_separate_blocks |
184.9 KB | 194.7 KB | -5.03% |
| ❌ | Simulation | hostname_ip_lookup[100000] |
167.4 µs | 174.9 µs | -4.3% |
| ❌ | Simulation | mv_single_file |
146.6 ms | 152.2 ms | -3.66% |
| ⚡ | Simulation | five_38_bit_primes |
1.9 s | 1.7 s | +16.68% |
| ⚡ | Simulation | three_39_bit_primes |
620.5 ms | 568.5 ms | +9.15% |
| ⚡ | Simulation | thirteen_39_bit_primes |
8.9 s | 8.6 s | +3.11% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Socialpranker:base-drop-error-prefix (fd29c57) with main (f56fe41)
Footnotes
-
54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
Flaky CI |
|
This seems a bit over-documented for such a trivial wording-only change. |
a8d7da6 to
4dd23b9
Compare
…sage The diagnostic already carries the program name, so the extra literal made it read "base64: error: invalid input" where GNU writes "base64: invalid input".
4dd23b9 to
fd29c57
Compare
Unable to generate the flame graphsThe performance report has correctly been generated, but there was an internal error while generating the flame graphs for this run. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |
|
fair, cut the description down |
This branch has not been deployed
3 participants
Drop the literal
error:from the invalid-input message; uucore already prints the program name, and GNU says justinvalid input:The messages are localised now (
base-common-invalid-input,encoding-error-invalid-input*). The partial-output difference is #6008, not touched here.Prepared with AI assistance (Claude Opus 5, via Claude Code).