Skip to content

build: rename and gate systemd_logind configuration - #13832

Open
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:feat_systemd_logind
Open

xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:feat_systemd_logind

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 9, 2026 •

Copy link
Copy Markdown
Collaborator

Rename the feat_systemd_logind feature to systemd_logind.

Prevent systemd_logind code from being enabled on unsupported platforms, improving cross-platform compilation and bringing the workspace closer to supporting:

cargo check -q --workspace --all-targets --all-features --target x86_64-pc-windows-gnu

@oech3

oech3 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

We remove it at #11579 .

@github-actions

github-actions Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.57 MB (+972 KB, +0.64%)

Significant per-binary changes:
  ls         2.11 MB ->    3.25 MB  (+1.14 MB, +54.36%)
  mkfifo     1.16 MB ->    1.08 MB  (-76 KB, -6.42%)
  mknod      1.16 MB ->    1.09 MB  (-76 KB, -6.38%)
  mkdir      1.16 MB ->    1.09 MB  (-72 KB, -6.04%)

@github-actions

github-actions Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)

@codspeed

codspeed Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 7 benchmarks

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 7 regressed benchmarks
✅ 377 untouched benchmarks
⏩ 62 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation five_38_bit_primes 1.5 s 1.8 s -16.61%
❌ Simulation expand_many_lines[100000] 95 ms 106.2 ms -10.53%
❌ Simulation tsort_complex_dag[50000] 87.6 ms 97.2 ms -9.79%
❌ Simulation expand_custom_tabstops[50000] 26.9 ms 29.6 ms -9.27%
❌ Simulation tsort_tree_dag[(10, 3)] 36.5 ms 39.4 ms -7.34%
❌ Simulation tsort_wide_dag[100000] 157.6 ms 167 ms -5.64%
❌ Simulation tsort_linear_chain[1000000] 1.9 s 2 s -4.75%
⚡ Simulation three_39_bit_primes 901.6 ms 378.6 ms ×2.4
⚡ Simulation join_french_locale 26.7 ms 24 ms +11.09%
⚡ Simulation join_full_match 26.7 ms 24 ms +11.08%
⚡ Simulation join_partial_overlap 22.1 ms 20.4 ms +8.36%
⚡ Simulation join_unicode_locale 2.6 ms 2.4 ms +6.65%
⚡ Simulation join_custom_separator 25.9 ms 24.4 ms +6.08%
⚡ Simulation rm_recursive_tree 14.4 ms 13.7 ms +5.28%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:feat_systemd_logind (f986fd3) with main (fe26d56)2

Open in CodSpeed

Footnotes

  1. 62 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (a5bc606) during the generation of this report, so fe26d56 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze
xtqqczze marked this pull request as draft August 9, 2026 19:25
@xtqqczze
xtqqczze force-pushed the feat_systemd_logind branch from ce647a1 to 3cf5970 Compare August 9, 2026 19:29
@xtqqczze
xtqqczze marked this pull request as ready for review August 29, 2026 10:45
@xtqqczze
xtqqczze force-pushed the feat_systemd_logind branch from 3cf5970 to 10225c8 Compare August 29, 2026 11:18
@xtqqczze

This comment was marked as outdated.

@xtqqczze
xtqqczze force-pushed the feat_systemd_logind branch from 10225c8 to 658d6d9 Compare August 29, 2026 16:55
@xtqqczze
xtqqczze force-pushed the feat_systemd_logind branch 2 times, most recently from b1c3a47 to e68a24b Compare September 15, 2026 11:45
@xtqqczze xtqqczze changed the title uucore: add target_os to systemd_logind cfg check build: rename and gate systemd_logind configuration Sep 15, 2026
@oech3

oech3 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

I think systemd is better if it can be renamed. But I prefer #11579 .

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@sylvestre Regardless of whether #11579 is desirable (and I think it probably is), I still think we should merge this in the meantime. The merge conflicts should be straightforward to resolve.

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@sylvestre Could you merge this please; I have changes depending on this.

Comment thread src/uucore/Cargo.toml
@xtqqczze
xtqqczze requested a review from sylvestre September 26, 2026 10:56
@xtqqczze
xtqqczze force-pushed the feat_systemd_logind branch 2 times, most recently from 0bf8d45 to feb5727 Compare September 27, 2026 14:16
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@sylvestre ready

@xtqqczze
xtqqczze force-pushed the feat_systemd_logind branch from feb5727 to f986fd3 Compare October 7, 2026 18:57
@oech3

oech3 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

I like --features systemd for the case someone started using libsystemd.so much more (and shorter name).

@xtqqczze

xtqqczze commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

I like --features systemd for the case someone started using libsystemd.so much more (and shorter name).

Currently we are not using general libsystemd functionality; just the systemd-logind subsystem. So it is shorter, but potentially misleading because it suggests broader integration than actually exists.

@oech3

oech3 commented Oct 7, 2026 via email

Copy link
Copy Markdown
Contributor

@xtqqczze

xtqqczze commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

It is not matter since we use openssl instead of openssl_api_name for cksum.

I think we have a feature named openssl to match the crate name, rather than anything particularly well considered.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants