[eduardomourar]

FileInformation previously fell back to a std::fs::Metadata-based heuristic (comparing file type and size) on WASI, since it lacked access to nix::sys::stat. Switch it to rustix::fs::Stat, the same backing type used on Unix, giving WASI real inode/device identity, nlink, and equality checks instead of an approximation. Also add WASI implementations of are_hardlinks_to_same_file and are_hardlinks_or_one_way_symlink_to_same_file via rustix::fs::stat/ lstat, since std::os::unix::fs::MetadataExt is unavailable there.

[codspeed]

Merging this PR will improve performance by 18.85%

1 warning, 1 note

⚠️ 119 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 1 improved benchmark
✅ 400 untouched benchmarks
⏩ 70 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	CPU Simulation	true_consecutive_calls	350.2 ns	294.7 ns	+18.85%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing eduardomourar:wasi-fs-inode-dev-stat (7d5286e) with main (679d1f2)²}

Footnotes

1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (eb7d426) during the generation of this report, so 679d1f2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/nocache_fail is now passing!
Note: The gnu test tests/rm/rm-readdir-fail was skipped on 'main' but is now failing.

[eduardomourar]

@sylvestre, this one is ready (now with proper testing in place).

[sylvestre]

Thanks, this looks much better: there's one rustix impl shared by unix and wasi now, the target-first early return is still there, and the tests run on wasi too. One nit left: the comment in fsext/mod.rs:142 can just be // ctime isn't exposed by std Metadata outside unix. Also, does any CI job actually run the uucore tests on wasi? If not, the new wasi cfgs are still untested.

[eduardomourar]

Done. Added a step to wasi.yml in order to run the unit tests for uucore.

[sylvestre]

Thanks, this looks much better: One nit left: the comment in fsext/mod.rs:142 can just be // ctime isn't exposed by std Metadata outside unix.
Also, does any CI job actually run the uucore tests on wasi? If not, the new wasi cfgs are still untested.