Skip to content

ci: pin ubuntu runner to 24.04 in workflows - #12292

Closed
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:pin-ubuntu
Closed

ci: pin ubuntu runner to 24.04 in workflows#12292
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:pin-ubuntu

Conversation

@xtqqczze

@xtqqczze xtqqczze commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes #12005

Pin the Ubuntu GitHub Actions runner version to avoid unintentionally introducing a dependency on the kernel and glibc version shipped with Ubuntu 26.04 when ubuntu-latest is updated. This ensures that future runner upgrades remain explicit and deliberate decisions.

@oech3

oech3 commented May 14, 2026

Copy link
Copy Markdown
Contributor

No. user should update their Ubuntu to 26.04 or use musl binary. This is not what we should care about.

@oech3

oech3 commented May 14, 2026

Copy link
Copy Markdown
Contributor

Also you are trying to remove the most important test cases.

@github-actions

github-actions Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tty-eof (passes in this run but fails in the 'main' branch)

@xtqqczze xtqqczze mentioned this pull request May 14, 2026
Open
@oech3

oech3 commented May 14, 2026

Copy link
Copy Markdown
Contributor

At least, this should be restricted to MSRV CI.

@xtqqczze

xtqqczze commented May 14, 2026

Copy link
Copy Markdown
Collaborator Author

I've pinned all Ubuntu jobs for now, though I agree we should be more specific.

@xtqqczze
xtqqczze marked this pull request as ready for review May 14, 2026 16:15
@oech3

oech3 commented May 14, 2026

Copy link
Copy Markdown
Contributor

Please stop. This does not help.

@oech3

oech3 commented May 14, 2026

Copy link
Copy Markdown
Contributor

One of a possibility is CI breakage caused by uutils/coreutils installed on Ubuntu 26.04, but it should be fixed by just apt-geting GNU.

@oech3 oech3 mentioned this pull request May 14, 2026
Closed
@oech3

oech3 commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please close this PR. I really don't want to use time for reverting your PR or bumping version.

Also you should try to use musl binary on Ubuntu 22.04 .
You don't need to install it.

@xtqqczze
xtqqczze force-pushed the pin-ubuntu branch 2 times, most recently from 6df4dc9 to 0c086f3 Compare May 29, 2026 19:46
@oech3

oech3 commented May 30, 2026

Copy link
Copy Markdown
Contributor

(Legacy Rust + latest Linux) and (Newest Rust + legacy Linux) does not making a sense. I suggest to just pin MinRustV CI only.
Pinning everything is not acceptible as it rejects catching regression for stty on the most common targets anyway.

@sylvestre
sylvestre enabled auto-merge (rebase) August 27, 2026 19:28
auto-merge was automatically disabled August 30, 2026 22:22

Head branch was pushed to by a user without write access

@xtqqczze
xtqqczze force-pushed the pin-ubuntu branch 2 times, most recently from 187f5ca to 140388d Compare August 30, 2026 23:05
@xtqqczze

This comment was marked as outdated.

Sign in to view
@xtqqczze
xtqqczze force-pushed the pin-ubuntu branch 3 times, most recently from 80c8a38 to fd54644 Compare September 16, 2026 09:58
oech3
oech3 reviewed Sep 19, 2026
View reviewed changes
Comment thread .github/workflows/android.yml
fail-fast: false
matrix:
os: [ubuntu-latest] # , macos-latest
os: [ubuntu-24.04] # , macos-latest

@oech3 oech3 May 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not making a sense. Binaries are linked against Android's libc.

oech3
oech3 reviewed Sep 19, 2026
View reviewed changes
Comment thread .github/workflows/benchmarks.yml
detects-benchmarks:
name: Detect changes on crates
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

@oech3 oech3 Sep 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most common consumers are ubuntu 26.* at here.

oech3
oech3 reviewed Sep 19, 2026
View reviewed changes
Comment thread .github/workflows/audit.yml
jobs:
audit:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

@oech3 oech3 Sep 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task is unrelated with host.

oech3
oech3 reviewed Sep 19, 2026
View reviewed changes
Comment thread .github/workflows/check-toml.yml
jobs:
check:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

@oech3 oech3 Sep 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task is unrelated with host.

oech3
oech3 reviewed Sep 19, 2026
View reviewed changes
Comment thread .github/workflows/CICD.yml
test_toctou:
name: TOCTOU Security Check
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

@oech3 oech3 Sep 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most common target is ubuntu 26.* at here.

oech3
oech3 reviewed Sep 19, 2026
View reviewed changes
Comment thread .github/workflows/code-quality.yml
- { os: ubuntu-latest , features: feat_wasm , target: wasm32-wasip1 }
- { os: ubuntu-latest , features: feat_wasm , target: wasm32-wasip2 }
- { os: ubuntu-24.04 , features: feat_wasm , target: wasm32-wasip1 }
- { os: ubuntu-24.04 , features: feat_wasm , target: wasm32-wasip2 }

@oech3 oech3 Sep 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Host is unrelated for this target.

oech3
oech3 reviewed Sep 19, 2026
View reviewed changes
Comment thread .github/workflows/fuzzing.yml
uufuzz-examples:
name: Build and test uufuzz examples
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

@oech3 oech3 Sep 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runner contains outdated GNU coreutils for our fuzzing,

@xtqqczze
xtqqczze marked this pull request as draft September 21, 2026 12:53
@xtqqczze xtqqczze closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@oech3 oech3 oech3 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build *-unknown-linux-gnu binaries with old glibc for portability

2 participants

@xtqqczze @oech3