Repository navigation
Conversation
|
GNU testsuite comparison: |
xtqqczze
force-pushed
the
dd-stdin-raw
branch
3 times, most recently
from
May 10, 2026 01:47
c2a52d4 to
07699da
Compare
2 of 3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
force-pushed
the
dd-stdin-raw
branch
8 times, most recently
from
May 10, 2026 19:36
2736ee9 to
e95946e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Merging this PR will improve performance by 30.08%
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
xtqqczze
force-pushed
the
dd-stdin-raw
branch
2 times, most recently
from
May 13, 2026 13:15
42e5ae2 to
a5a2281
Compare
xtqqczze
commented
May 13, 2026
xtqqczze
marked this pull request as ready for review
May 13, 2026 15:46
xtqqczze
marked this pull request as draft
May 21, 2026 17:49
xtqqczze
marked this pull request as ready for review
May 24, 2026 13:44
xtqqczze
force-pushed
the
dd-stdin-raw
branch
5 times, most recently
from
September 5, 2026 07:47
b6d885e to
657641d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
force-pushed
the
dd-stdin-raw
branch
from
September 5, 2026 09:22
657641d to
02064e3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
marked this pull request as draft
September 5, 2026 12:59
xtqqczze
force-pushed
the
dd-stdin-raw
branch
from
September 7, 2026 21:19
02064e3 to
73303d9
Compare
xtqqczze
marked this pull request as ready for review
September 8, 2026 02:44
xtqqczze
force-pushed
the
dd-stdin-raw
branch
from
September 12, 2026 13:00
73303d9 to
8ff3ce3
Compare
xtqqczze
marked this pull request as draft
September 25, 2026 17:37
xtqqczze
force-pushed
the
dd-stdin-raw
branch
from
September 25, 2026 18:33
8ff3ce3 to
dd8a17a
Compare
Introduce safe wrappers for raw stdin, stdout, and stderr backed by `ManuallyDrop<File>`. `ManuallyDrop` ensures the underlying standard stream file descriptors are not closed when the wrappers are dropped. The wrappers only expose shared or mutable references to the underlying `File`, preventing safe code from taking ownership and accidentally closing the descriptors.
xtqqczze
force-pushed
the
dd-stdin-raw
branch
from
October 14, 2026 21:36
dd8a17a to
51e62cc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce safe wrappers for raw stdio backed by
ManuallyDrop<File>. TheManuallyDropprevents the file descriptor from being closed on drop, which could otherwise lead to undefined behavior.The wrapper only exposes
&File, so safe code cannot take ownership and accidentally drop the underlying descriptor.