Skip to content

test(cksum): regression test for write errors to /dev/full - #10978

Closed
naoNao89 wants to merge 1 commit into
uutils:mainfrom
naoNao89:fix-cksum-stdout-panic
Closed

test(cksum): regression test for write errors to /dev/full#10978
naoNao89 wants to merge 1 commit into
uutils:mainfrom
naoNao89:fix-cksum-stdout-panic

Conversation

@naoNao89

@naoNao89 naoNao89 commented Feb 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds a Linux-only regression test verifying that cksum exits with code 1 (instead of panicking) when stdout is /dev/full.

Refs #10947, which has been fixed by #12099. Per @xtqqczze's suggestion in this comment, this PR has been reduced to the regression test only; the original implementation has been dropped.

@github-actions

github-actions Bot commented Feb 16, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Note: The gnu test tests/pr/bounded-memory is now being skipped but was previously passing.

@xtqqczze

xtqqczze commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

As per #10536, any functions that now take impl Write should be renamed.

xtqqczze
xtqqczze reviewed Feb 16, 2026
View reviewed changes
Comment thread src/uucore/src/lib/features/checksum/compute.rs Outdated
@naoNao89
naoNao89 force-pushed the fix-cksum-stdout-panic branch from 49f72b6 to 8624081 Compare February 16, 2026 16:17
@github-actions

github-actions Bot commented Feb 16, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.

@github-actions

github-actions Bot commented Feb 16, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/cut/bounded-memory. tests/cut/bounded-memory is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/seq/seq-epipe. tests/seq/seq-epipe is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!

xtqqczze
xtqqczze approved these changes Feb 17, 2026
View reviewed changes

@xtqqczze xtqqczze left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update comments like "Print the filename" to "Write the filename"

@github-actions

github-actions Bot commented Feb 17, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/cut/bounded-memory. tests/cut/bounded-memory is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/date/resolution. tests/date/resolution is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!

@oech3

oech3 commented May 4, 2026

Copy link
Copy Markdown
Contributor

Fixed by different PR

@xtqqczze

xtqqczze commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Indeed, fixed by #12099.

It may still be worthwhile merging the regression test from this PR.

@naoNao89
test(cksum): regression test for write errors to /dev/full
68e777d 
Adds a Linux-only regression test that verifies cksum exits with
code 1 (rather than panicking) when stdout is /dev/full.

Refs uutils#10947 (fixed by uutils#12099).
@naoNao89
naoNao89 force-pushed the fix-cksum-stdout-panic branch from 0a6366a to 68e777d Compare May 6, 2026 04:02
@naoNao89 naoNao89 changed the title fix(checksum): handle stdout write errors gracefully instead of panic… test(cksum): regression test for write errors to /dev/full May 6, 2026
@naoNao89

naoNao89 commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

tks for the feedback. Covert this PR down to just the regression test since #12099 already landed the fix

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/misc/tty-eof. tests/misc/tty-eof is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.

@RenjiSann

RenjiSann commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #15557

@RenjiSann RenjiSann closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xtqqczze xtqqczze xtqqczze approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@naoNao89 @xtqqczze @oech3 @RenjiSann