Skip to content

feat: allow to acknowledge pullrequest - #349

Merged
olblak merged 3 commits into
updatecli:mainfrom
olblak:feat/acknowledge-pull-requests
Oct 10, 2026
Merged

feat: allow to acknowledge pullrequest#349
olblak merged 3 commits into
updatecli:mainfrom
olblak:feat/acknowledge-pull-requests

Conversation

@olblak

@olblak olblak commented Oct 10, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Require updatecli/udash#480

Description

Test

To test this pull request, you can run the following commands:

Additional Information

Tradeoff

Potential improvement

Summary by CodeRabbit

  • New Features
    • Pull requests can now be acknowledged for 1, 7, or 30 days, with an option to undo an acknowledgement.
    • View acknowledged pull requests separately and restore them to the main list.
    • Acknowledgement controls and status updates support keyboard and touch interaction.
  • Bug Fixes
    • Improved handling of acknowledgement failures and unavailable acknowledged lists.
    • Prevented duplicate requests when Undo is clicked repeatedly.

olblak added 3 commits October 10, 2026 12:38
@olblak
fix(api): return null for a response without a body
919ad0b 
A 204 has no JSON to decode, so response.json() rejected and a
successful change looked like a failure.
@olblak
feat(api): let a caller explain a 401 itself
17202eb 
apiFetch gains signInOnUnauthorized (default true). An action the
viewer triggered can pass false to show an inline message and a Sign
in button instead of leaving the page for the login mid click.
currentReturnTo is exported so that button can return to the page.
@olblak
feat: acknowledge pull requests waiting to be merged
b2e3527 
Each open pull request can be acknowledged for 1, 7 or 30 days, for the
whole team. It leaves the list until the time is up or its worst result
changes. The list shows how many it hides, and the acknowledged view
lists them with who acknowledged them and offers Unacknowledge. A fresh
acknowledgement can be undone from the notice.

The control is shown to every viewer and the API decides: a refusal is
explained inline, with a Sign in button when signing in would help.
@olblak olblak added the enhancement New feature or request label Oct 10, 2026
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1f4420c1-e5fc-46c7-bb5c-65d1a90dba8a
📥 Commits

Reviewing files that changed from the base of the PR and between c08712e and b2e3527.

📒 Files selected for processing (6)
  • src/components/PullRequestList.spec.js
  • src/components/PullRequestList.vue
  • src/composables/api.js
  • src/composables/api.spec.js
  • src/composables/auth.js
  • src/plugins/icons.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The pull request list now supports acknowledged items, acknowledgement durations, restoration, and undo. It submits the selected duration and pipeline result through the API and displays request errors and success notices.

Changes

Pull request acknowledgements

Layer / File(s) Summary
API request behavior
src/composables/api.js, src/composables/api.spec.js, src/composables/auth.js		 apiFetch can suppress automatic sign-in handling for 401 responses and returns null for successful 204 responses. currentReturnTo is exported.
Acknowledged list and row controls
src/components/PullRequestList.vue, src/components/PullRequestList.spec.js		 The list can display acknowledged items and their metadata, switch between acknowledged and waiting views, and show the corresponding count and empty state.
Acknowledgement changes and feedback
src/components/PullRequestList.vue, src/components/PullRequestList.spec.js, src/plugins/icons.js		 Rows can be acknowledged for 1, 7, or 30 days, unacknowledged, or restored with Undo. The component handles request errors, updates the list, and displays notices. New icons support the controls.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Reader
  participant PullRequestList
  participant apiFetch
  participant AcknowledgementAPI
  Reader->>PullRequestList: Select acknowledgement duration
  PullRequestList->>apiFetch: Send PUT with duration and result
  apiFetch->>AcknowledgementAPI: Submit acknowledgement request
  AcknowledgementAPI-->>apiFetch: Return response
  apiFetch-->>PullRequestList: Return response or request error
  PullRequestList->>apiFetch: Reload current list after success
Loading

Merge Risk: ⚪ Minimal · up to b2e35

No merge-blocking issue is established for the acknowledgement changes. Normal validation can proceed.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the main change: adding pull request acknowledgements. “Pullrequest” is a minor wording issue, but the title remains clear and specific.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olblak
olblak merged commit 415c904 into updatecli:main Oct 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@olblak