Repository navigation
Answer 400 to a request target that is not visible ASCII - #1951
Merged
uNetworkingAB merged 1 commit intoOct 2, 2026
Merged
Conversation
nigrosimone
marked this pull request as ready for review
October 2, 2026 06:08
Contributor
|
I get 157/159 with all your recent PRs |
Contributor
Author
157/159 isn't cool, 159/159 is cool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw UTF-8 in the request target gets 200 (Http11Probe MAL-NON-ASCII-URL and MAL-URL-OVERLONG-UTF8). RFC 9112 3.2 builds the target from URI characters, so visible ASCII only. Node.js answers 400 to both.
The fix makes the word scan in consumeRequestLine stop also on a byte over 126, and the byte loop fail on it. It costs 4 instructions every 8 bytes of target.
The new test sends three targets, one long enough that only the word scan sees the UTF-8. It fails without the fix.
With Http11Probe locally only these two tests move, from Fail to Pass.